[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] target-i386: implement CPUID[0xB] (Extended
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] target-i386: implement CPUID[0xB] (Extended Topology Enumeration) |
|
Date: |
Fri, 27 May 2016 16:12:12 -0300 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, May 12, 2016 at 07:24:26PM +0200, Radim Krčmář wrote:
> I looked at a dozen Intel CPU that have this CPUID and all of them
> always had Core offset as 1 (a wasted bit when hyperthreading is
> disabled) and Package offset at least 4 (wasted bits at <= 4 cores).
>
> QEMU uses more compact IDs and it doesn't make much sense to change it
> now. I keep the SMT and Core sub-leaves even if there is just one
> thread/core; it makes the code simpler and there should be no harm.
>
> Signed-off-by: Radim Krčmář <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Applied to x86-next.
--
Eduardo