qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence


From: Sergey Fedorov
Subject: Re: [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence
Date: Fri, 27 May 2016 13:23:49 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0

On 27/05/16 04:00, Richard Henderson wrote:
> diff --git a/tci.c b/tci.c
> index b488c0d..53b3f71 100644
> --- a/tci.c
> +++ b/tci.c
> @@ -1236,6 +1236,9 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t 
> *tb_ptr)
>                  tcg_abort();
>              }
>              break;
> +        case INDEX_op_fence:
> +            smp_mb();
> +            break;
>          default:
>              TODO();
>              break;

A bit of bike-shedding. While there's no common ISA term for "memory
barrier" (also known as a "membar", "memory fence", etc.), we already
refer to it as a "memory barrier" (or "mb") in include/qemu/atomic.h and
docs/atomics.txt. Why don't be consistent and avoid introducing yet
another term for the same thing?

Kind regards,
Sergey



reply via email to

[Prev in Thread] Current Thread [Next in Thread]