[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc/fpu_helper: Fix efscmp* i
From: |
Imran, Talha |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc/fpu_helper: Fix efscmp* instructions handling |
Date: |
Fri, 27 May 2016 07:43:46 +0000 |
On 05/27/2016 06:37 AM, David Gibson wrote:
> On Thu, May 19, 2016 at 05:11:35PM +0500, Talha Imran wrote:
>> With specification at hand from the reference manual from Freescale
>> http://cache.nxp.com/files/32bit/doc/ref_manual/SPEPEM.pdf , I have found a
>> fix
>> to efscmp* instructions handling in QEMU.
>>
...
>> Signed-off-by: Talha Imran <address@hidden>
>
> Does this patch supersede the earlier patch you posted for efcmp
> instructions on e500v1? Or is it in addition to that patch?
>
[talha]: Yes, it supersedes the earlier patches. This is a better solution.
>> ---
>> target-ppc/fpu_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c
>> index b67ebca..6fd56a8 100644
>> --- a/target-ppc/fpu_helper.c
>> +++ b/target-ppc/fpu_helper.c
>> @@ -1442,7 +1442,7 @@ static inline uint32_t efststeq(CPUPPCState *env,
>> uint32_t op1, uint32_t op2)
>> #define HELPER_SINGLE_SPE_CMP(name) \
>> uint32_t helper_e##name(CPUPPCState *env, uint32_t op1, uint32_t op2) \
>> { \
>> - return e##name(env, op1, op2) << 2; \
>> + return e##name(env, op1, op2); \
>> }
>> /* efststlt */
>> HELPER_SINGLE_SPE_CMP(fststlt);
>