[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/14] block: Cancel jobs first in bdrv_close
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/14] block: Cancel jobs first in bdrv_close_all() |
Date: |
Tue, 24 May 2016 16:29:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/24/2016 07:47 AM, Kevin Wolf wrote:
> So far, bdrv_close_all() first removed all root BlockDriverStates of
> BlockBackends and monitor owned BDSes, and then assumed that the
> remaining BDSes must be related to jobs and cancelled these jobs.
>
> This order doesn't work that well any more when block jobs use
> BlockBackends internally because then they will lose their BDS before
> being cancelled.
>
> This patch changes bdrv_close_all() to first cancel all jobs and then
> remove all root BDSes from the remaining BBs.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 23 ++---------------------
> blockjob.c | 13 +++++++++++++
> include/block/blockjob.h | 7 +++++++
> 3 files changed, 22 insertions(+), 21 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/14] block jobs: Convert I/O to BlockBackend, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 03/14] block: Default to enabled write cache in blk_new(), Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 02/14] block: Cancel jobs first in bdrv_close_all(), Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 01/14] block: keep a list of block jobs, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 04/14] block: Convert block job core to BlockBackend, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 09/14] backup: Don't leak BackupBlockJob in error path, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 10/14] backup: Pack Notifier within BackupBlockJob, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 07/14] mirror: Allow target that already has a BlockBackend, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 08/14] mirror: Use BlockBackend for I/O, Kevin Wolf, 2016/05/24