[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] trace: move qemu_trace_opts to trace/contro
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] trace: move qemu_trace_opts to trace/control.c |
Date: |
Thu, 19 May 2016 17:15:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
> The patch also creates trace_opt_parse() helper in trace/control.c to reuse
> this code in next patches for qemu-nbd and qemu-io.
>
> The patch also makes trace_init_events() static, as this call is not used
> outside the module anymore.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> trace/control.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
> trace/control.h | 24 +++++++++++++-----------
> vl.c | 37 +------------------------------------
> 3 files changed, 57 insertions(+), 48 deletions(-)
>
>
> +QemuOptsList qemu_trace_opts = {
> + .name = "trace",
> + .implied_opt_name = "enable",
> + .head = QTAILQ_HEAD_INITIALIZER(qemu_trace_opts.head),
> + .desc = {
> + {
> + .name = "enable",
> + .type = QEMU_OPT_STRING,
> + },
> + {
> + .name = "events",
> + .type = QEMU_OPT_STRING,
> + },{
I know this is straight code motion, but we aren't very consistent on
spacing between elements. Might be worth the extra newline here while
touching it?
> + .name = "file",
> + .type = QEMU_OPT_STRING,
> + },
> + { /* end of list */ }
> + },
> +};
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/3] trace: enable tracing in qemu-io/qemu-nbd, Denis V. Lunev, 2016/05/17
- [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io, Denis V. Lunev, 2016/05/17
- [Qemu-devel] [PATCH 1/3] trace: move qemu_trace_opts to trace/control.c, Denis V. Lunev, 2016/05/17
- Re: [Qemu-devel] [PATCH 1/3] trace: move qemu_trace_opts to trace/control.c,
Eric Blake <=
- [Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd, Denis V. Lunev, 2016/05/17
- Re: [Qemu-devel] [PATCH 0/3] trace: enable tracing in qemu-io/qemu-nbd, Paolo Bonzini, 2016/05/17
- Re: [Qemu-devel] [PATCH 0/3] trace: enable tracing in qemu-io/qemu-nbd, Stefan Hajnoczi, 2016/05/27