[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 6/6] Postcopy: Check for support when setting the
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PATCH v4 6/6] Postcopy: Check for support when setting the capability |
Date: |
Tue, 17 May 2016 13:55:55 +0100 |
From: "Dr. David Alan Gilbert" <address@hidden>
Knowing whether the destination host supports migration with
postcopy can be tricky.
The destination doesn't need the capability set, however
if we set it then use the opportunity to do the test and
tell the user/management layer early.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/migration.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 9d41618..9e4ba8c 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -675,6 +675,7 @@ void
qmp_migrate_set_capabilities(MigrationCapabilityStatusList *params,
{
MigrationState *s = migrate_get_current();
MigrationCapabilityStatusList *cap;
+ bool old_postcopy_cap = migrate_postcopy_ram();
if (migration_is_setup_or_active(s->state)) {
error_setg(errp, QERR_MIGRATION_ACTIVE);
@@ -697,6 +698,19 @@ void
qmp_migrate_set_capabilities(MigrationCapabilityStatusList *params,
s->enabled_capabilities[MIGRATION_CAPABILITY_POSTCOPY_RAM] =
false;
}
+ /* This check is reasonably expensive, so only when it's being
+ * set the first time, also it's only the destination that needs
+ * special support.
+ */
+ if (!old_postcopy_cap && runstate_check(RUN_STATE_INMIGRATE) &&
+ !postcopy_ram_supported_by_host()) {
+ /* postcopy_ram_supported_by_host will have emitted a more
+ * detailed message
+ */
+ error_report("Postcopy is not supported");
+ s->enabled_capabilities[MIGRATION_CAPABILITY_POSTCOPY_RAM] =
+ false;
+ }
}
}
--
2.5.5
- [Qemu-devel] [PATCH v4 0/6] postcopy (& 1 test) patch for 2.7, Dr. David Alan Gilbert (git), 2016/05/17
- [Qemu-devel] [PATCH v4 1/6] Postcopy: Avoid 0 length discards, Dr. David Alan Gilbert (git), 2016/05/17
- [Qemu-devel] [PATCH v4 2/6] Migration: Split out ram part of qmp_query_migrate, Dr. David Alan Gilbert (git), 2016/05/17
- [Qemu-devel] [PATCH v4 3/6] Postcopy: Add stats on page requests, Dr. David Alan Gilbert (git), 2016/05/17
- [Qemu-devel] [PATCH v4 4/6] test: Postcopy, Dr. David Alan Gilbert (git), 2016/05/17
- [Qemu-devel] [PATCH v4 5/6] tests: fix libqtest socket timeouts, Dr. David Alan Gilbert (git), 2016/05/17
- [Qemu-devel] [PATCH v4 6/6] Postcopy: Check for support when setting the capability,
Dr. David Alan Gilbert (git) <=