|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH] cpu-exec: Clean up 'interrupt_request' reloading in cpu_handle_interrupt() |
Date: | Thu, 12 May 2016 06:47:00 -1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 05/12/2016 04:14 AM, Sergey Fedorov wrote:
@@ -489,9 +489,10 @@ static inline void cpu_handle_interrupt(CPUState *cpu, *last_tb = NULL; }
[A]
} - /* Don't use the cached interrupt_request value, - do_interrupt may have updated the EXITTB flag. */ - if (cpu->interrupt_request & CPU_INTERRUPT_EXITTB) { + /* The target hook may have updated the 'cpu->interrupt_request'; + * reload the 'interrupt_request' value */ + interrupt_request = cpu->interrupt_request; + if (interrupt_request & CPU_INTERRUPT_EXITTB) {
Actually I suggested reloading it after the only place it could have changed, at A. r~
[Prev in Thread] | Current Thread | [Next in Thread] |