Re: [Qemu-devel] [PULL 00/12] ui patch queue

[Peter Maydell]

On 10 May 2016 at 06:51, Gerd Hoffmann <address@hidden> wrote:
>   Hi,
>
> First UI pull request for 2.7.  Brings a bunch of build tweaks for gtk
> and sdl.  Fixes the gtk 3.20 deprication warnings.  Some stuff piled
> up during the freeze.
>
> please pull,
>   Gerd
>
> The following changes since commit 975eb6a547f809608ccb08c221552f666611af25:
>
>   Update version for v2.6.0-rc4 release (2016-05-02 17:27:01 +0100)
>
> are available in the git repository at:
>
>   git://git.kraxel.org/qemu tags/pull-ui-20160510-1
>
> for you to fetch changes up to da2e1221d7d19f2506fb04eca255a4fee4fc5f6b:
>
>   spice/gl: add & use qemu_spice_gl_monitor_config (2016-05-10 07:43:46 +0200)
>
> ----------------------------------------------------------------
> gtk/sdl build tweaks
> fix gtk 3.20 warnings
> gtk clipboard support
> spice-gl monitor config support

Commiserations on the first failed-to-build pullreq of the 2.7 cycle:

/home/pm215/qemu/ui/gtk.c: In function ‘gd_menu_copy’:
/home/pm215/qemu/ui/gtk.c:1270:21: error: unused variable ‘vc’
[-Werror=unused-variable]
     VirtualConsole *vc = gd_vc_find_current(s);
                     ^

This was on ppc64be Linux, though I'm guessing that's just because
it's the only system that happens not to define CONFIG_VTE.

(Q: should we even put the "Copy" entry into the menu if we can't
actually support copying text ?)

thanks
-- PMM