[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/7] ipmi: Fix SSIF ACPI handling to use the rig
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 6/7] ipmi: Fix SSIF ACPI handling to use the right CRS |
Date: |
Thu, 12 May 2016 10:33:15 +0300 |
On Wed, May 11, 2016 at 02:46:05PM -0500, address@hidden wrote:
> From: Corey Minyard <address@hidden>
>
> Signed-off-by: Corey Minyard <address@hidden>
> ---
> hw/acpi/ipmi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/acpi/ipmi.c b/hw/acpi/ipmi.c
> index 731f4ad..c187fdd 100644
> --- a/hw/acpi/ipmi.c
> +++ b/hw/acpi/ipmi.c
> @@ -49,7 +49,9 @@ static Aml *aml_ipmi_crs(IPMIFwInfo *info)
> regspacing, info->register_length));
> break;
> case IPMI_MEMSPACE_SMBUS:
> - aml_append(crs, aml_return(aml_int(info->base_address)));
> + aml_append(crs, aml_i2c_serial_bus_device(0, 100000,
> + info->base_address,
> + info->acpi_parent));
Isn't this fairly new? If so using these opcodes
is likely to break some older guests. Maybe they already don't
work, but I'd like to see some explanation about that,
and what was tested.
> break;
> default:
> abort();
> --
> 2.7.4
[Qemu-devel] [PATCH 4/7] ipmi: Add an SMBus IPMI interface, minyard, 2016/05/11
[Qemu-devel] [PATCH 6/7] ipmi: Fix SSIF ACPI handling to use the right CRS, minyard, 2016/05/11
- Re: [Qemu-devel] [PATCH 6/7] ipmi: Fix SSIF ACPI handling to use the right CRS,
Michael S. Tsirkin <=
[Qemu-devel] [PATCH 5/7] acpi: Add I2c serial bus CRS handling, minyard, 2016/05/11
[Qemu-devel] [PATCH 3/7] pc: Add the SMBus device to the ACPI tables, minyard, 2016/05/11
[Qemu-devel] [PATCH 1/7] i2c: Fix the PM SMBus driver so it actually works correctly, minyard, 2016/05/11