[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] cpu-exec: Move exception handling out of cp
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] cpu-exec: Move exception handling out of cpu_exec() |
Date: |
Tue, 10 May 2016 22:21:23 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 |
On 10/05/16 19:21, Richard Henderson wrote:
> On 05/10/2016 05:46 AM, Sergey Fedorov wrote:
>> From: Sergey Fedorov <address@hidden>
>>
>> Simplify cpu_exec() by extracting exception handling code out of
>> cpu_exec() into a new static inline function cpu_handle_exception().
>> Also make cpu_handle_debug_exception() inline as it is used only once.
>
> If it's used only once, the compiler is going to do this anyway, and
> therefore there's no point in making the change. Let's just leave off
> all the inline markers and trust the compiler, eh?
I agree the compiler is smart enough to decide and inline such functions
by itself. But actually, I hope such "static inline" in .c file could
indicate for a reader of the code that this function is going to be used
this way.
>
> Otherwise,
>
> Reviewed-by: Richard Henderson <address@hidden>
Kind regards,
Sergey
- [Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 2/5] cpu-exec: Move exception handling out of cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 4/5] cpu-exec: Move TB execution stuff out of cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 5/5] cpu-exec: Remove unused 'x86_cpu' and 'env' from cpu_exec(), Sergey Fedorov, 2016/05/10
- [Qemu-devel] [PATCH 3/5] cpu-exec: Move interrupt handling out of cpu_exec(), Sergey Fedorov, 2016/05/10
- Re: [Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec(), Sergey Fedorov, 2016/05/10