[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 18/27] mirror: Disable image locking on target ba
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v4 18/27] mirror: Disable image locking on target backing chain |
Date: |
Tue, 10 May 2016 10:50:50 +0800 |
In sync=none the backing image of s->target is s->common.bs, which could
be exclusively locked, the image locking wouldn't work here.
Later we can update completion code to lock it after the replaced node
has dropped its lock.
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index e3882d6..9968568 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3617,6 +3617,12 @@ void qmp_drive_mirror(const char *device, const char
*target,
* file.
*/
target_bs = NULL;
+ if (sync == MIRROR_SYNC_MODE_NONE) {
+ flags |= BDRV_O_NO_LOCK;
+ }
+ /* TODO: in mirror complete, after target_bs is switched to and the
+ * original BDS's lock is dropped, we should enable the lock on target_bs.
+ * */
ret = bdrv_open(&target_bs, target, NULL, options,
flags | BDRV_O_NO_BACKING, &local_err);
if (ret < 0) {
--
2.8.2
- Re: [Qemu-devel] [PATCH v4 08/27] osdep: Add qemu_lock_fd and qemu_unlock_fd, (continued)
- [Qemu-devel] [PATCH v4 10/27] raw-posix: Use qemu_dup, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 11/27] raw-posix: Implement .bdrv_lockf, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 13/27] qemu-io: Add "-L" option for BDRV_O_NO_LOCK, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 12/27] gluster: Implement .bdrv_lockf, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 15/27] qemu-img: Update documentation of "-L" option, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 16/27] qemu-nbd: Add "--no-lock/-L" option, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 14/27] qemu-img: Add "-L" option to sub commands, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 17/27] block: Don't lock drive-backup target image in none mode, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 18/27] mirror: Disable image locking on target backing chain,
Fam Zheng <=
- [Qemu-devel] [PATCH v4 20/27] qemu-iotests: 046: Move version detection out from verify_io, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 22/27] qemu-iotests: 030: Disable image lock when checking test image, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 19/27] qemu-iotests: 140: Disable image lock for qemu-io access, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 24/27] iotests: Disable image locking in 085, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 21/27] qemu-iotests: Wait for QEMU processes before checking image in 091, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 23/27] iotests: 087: Disable image lock in cases where file is shared, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 26/27] block: Turn on image locking by default, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 25/27] tests: Use null-co:// instead of /dev/null, Fam Zheng, 2016/05/09
- [Qemu-devel] [PATCH v4 27/27] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2016/05/09
- Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening, Richard W.M. Jones, 2016/05/10