[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] Dump: add command "fuse-mount"
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] Dump: add command "fuse-mount" |
Date: |
Mon, 9 May 2016 10:48:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/07/2016 05:32 PM, Nan Li wrote:
> Add a "fuse-mount" command to support the Filesystem in Userspace (FUSE).
> It can mount or unmount the filesystem with both hmp and qmp commands.
> It calls the API function qemu_fuse_main(int argc, char *argv[]).
>
> Signed-off-by: Nan Li <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -2283,6 +2283,21 @@
> 'returns': 'DumpGuestMemoryCapability' }
>
> ##
> +# @fuse-mount:
> +#
> +# mount(unmount) fuse system on 'mountpoint'.
> +#
> +# @is_mount: optional if true, umount the fuse system from the mount point
s/umount/unmount/
New QMP commands should favor the use of '-' rather than '_' (as in
'is-mount'). But the name 'is_mount' does not even appear below, so you
aren't documenting reality.
> +#
> +# @mountpoint: the mount point (a path) of fuse system
> +#
> +# Returns: Nothing on success
> +#
> +# Since: 2.6
You've missed 2.6. This has to be 2.7 or later.
> +##
> +{ 'command': 'fuse-mount', 'data': {'unmount': 'bool', 'mountpoint': 'str'} }
> +
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace, (continued)
- Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace, Stefan Hajnoczi, 2016/05/10
- Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace, Nan Li, 2016/05/10
- Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace, Petr Tesarik, 2016/05/10
- Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace, Stefan Hajnoczi, 2016/05/12
- Re: [Qemu-devel] [PATCH 1/2] Dump: introduce a Filesystem in Userspace, Petr Tesarik, 2016/05/12
[Qemu-devel] [PATCH 2/2] Dump: add command "fuse-mount", Nan Li, 2016/05/09
Re: [Qemu-devel] [PATCH 0/2] Dump: add a Filesystem in Userspace and command "fuse-mount", Stefan Hajnoczi, 2016/05/10
Re: [Qemu-devel] [PATCH 0/2] Dump: add a Filesystem in Userspace and command "fuse-mount", Stefan Hajnoczi, 2016/05/10