qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use s390 target space addr


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use s390 target space address instead of host space address for restorer
Date: Wed, 4 May 2016 17:06:06 +0100

On 29 March 2016 at 15:29,  <address@hidden> wrote:
> From: Chen Gang <address@hidden>
>
> The return address is in target space, so the restorer address needs to
> be target space, too.
>
> Signed-off-by: Chen Gang <address@hidden>
> ---
>  linux-user/signal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index c0a6f7e..6a73321 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -4117,8 +4117,8 @@ static void setup_frame(int sig, struct 
> target_sigaction *ka,
>              env->regs[14] = (unsigned long)
>                      ka->sa_restorer | PSW_ADDR_AMODE;
>      } else {
> -            env->regs[14] = (unsigned long)
> -                    frame->retcode | PSW_ADDR_AMODE;
> +            env->regs[14] = (frame_addr + offsetof(sigframe, retcode))
> +                            | PSW_ADDR_AMODE;
>              __put_user(S390_SYSCALL_OPCODE | TARGET_NR_sigreturn,
>                         (uint16_t *)(frame->retcode));
>      }

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]