Re: [Qemu-devel] [PATCH v3 08/18] qjson: Simplify by using json-output-visitor

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Eric Blake <address@hidden> writes:
>
>> Instead of rolling our own limited JSON outputter, we can just
>> wrap the more full-featured JSON output Visitor.
>>
>> This slightly changes the output (different spacing), but the
>> result is still equivalent JSON contents.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>
> The file comment
>
>   /*
>    * QEMU JSON writer
>    *
>
> becomes misleading.  This isn't "the" QEMU JSON writer.  It's not even
> "a" JSON writer anymore.  It's a (QOM) object to accumulate JSON in a
> limited way.
>
> Why it's a *QOM* object I can't see.
>
> If I take the QOMness away, all that's left is a thin, trivial wrapper
> around the visitor.  Why is it useful?

Oh, now I see: you asked yourself the same question, and PATCH 10+11 are
the result.

The weekend deleted the cover letter from my memory %-)