[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.6 2/3] replay: Fix dangling location bug i
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.6 2/3] replay: Fix dangling location bug in replay_configure() |
|
Date: |
Wed, 27 Apr 2016 13:39:09 -0300 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Apr 27, 2016 at 04:29:08PM +0200, Markus Armbruster wrote:
> replay_configure() pushes and pops a Location with automatic storage
> duration. Except it fails to pop when -icount parameter "rr" isn't
> given. cur_loc then points to unused stack space, and will most
> likely get clobbered in short order.
>
> Clobbered cur_loc can make loc_pop() and error_print_loc() crash or
> report bogus locations.
>
> Broken in commit 890ad55.
>
> I didn't take the time to find a reproducer.
>
> Cc: Eduardo Habkost <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
Oops! Thanks for catching it.
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo