Re: [Qemu-devel] [PATCH for-2.7 0/8] libqos: use standard virtio headers

[Stefan Hajnoczi]

On Mon, Apr 25, 2016 at 03:09:14PM -0400, John Snow wrote:
> On 04/25/2016 08:46 AM, Stefan Hajnoczi wrote:
> > This patch series eliminates code duplication in libqos virtio.
> > include/standard-headers/ contains the Linux virtio header files so we don't
> > need to define our own version of the structs and constants.
> > 
> 
> Is that a good idea? I had thought some of the intentional purpose of
> duplicating the headers was to test the other versions.

There is already a way to verify that the Linux virtio structs and
constants are correct: compare against the virtio specification.

The duplication adds extra work for anyone writing virtio device tests.
We need more tests, which won't happen if it's a pain to write tests.
Most likely the constants will just be copy-pasted from Linux anyway, so
I don't see any benefit in duplication.

Stefan

signature.asc
Description: PGP signature