Re: [Qemu-devel] [PATCH 2.6 candidate] usb/uhci: move pid check

[Peter Maydell]

On 22 April 2016 at 11:44, Gerd Hoffmann <address@hidden> wrote:
> commit "5f77e06 usb: add pid check at the first of uhci_handle_td()"
> moved the pid verification to the start of the uhci_handle_td function,
> to simplify the error handling (we don't have to free stuff which we
> didn't allocate in the first place ...).
>
> Problem is now the check fires too often, it raises error IRQs even for
> TDs which we are not going to process because they are not set active.
>
> So, lets move down the check a bit, so it is done only for active TDs,
> but still before we are going to allocate stuff to process the requested
> transfer.
>
> Reported-by: Joe Clifford <address@hidden>
> Tested-by: Joe Clifford <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>

Applied to master, thanks.

-- PMM