Re: [Qemu-devel] [PATCH 1/2] seccomp: Whitelist cacheflush since 2.2.0 not 2.2.3

[Peter Maydell]

On 8 April 2016 at 12:45, Andrew Jones <address@hidden> wrote:
> On Mon, Apr 04, 2016 at 09:29:15AM +0100, James Hogan wrote:
>> The cacheflush system call (found on MIPS and ARM) has been included in
>> the libseccomp header since 2.2.0, so include include it back to that
>> version. Previously it was only enabled since 2.2.3 since that is when
>> it was enabled properly for ARM.
>>
>> This will allow seccomp support to be enabled for MIPS back to
>> libseccomp 2.2.0.
>>
>> Signed-off-by: James Hogan <address@hidden>
>> Cc: Eduardo Otubo <address@hidden>
>> Cc: Aurelien Jarno <address@hidden>
>> ---
>>  qemu-seccomp.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> Reviewed-By: Andrew Jones <address@hidden>

Andrew: when we originally put this ifdeffery in you said
"libseccomp didn't know about cacheflush until 2.2.1, and we
 require 2.2.3 for other reasons"
(https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg07258.html)

Has something changed, were you just wrong back then, or have
you forgotten something this time around? (Do you remember what
the "other reasons" were?)

thanks
-- PMM