[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and oth
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?) |
Date: |
Mon, 4 Apr 2016 16:57:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 04/04/2016 16:56, Peter Maydell wrote:
> On 4 April 2016 at 15:44, Paolo Bonzini <address@hidden> wrote:
>> On 04/04/2016 16:35, Alex Bennée wrote:
>>> Only the first patch has actually changed. Instead of moving the read
>>> inside the write seqlock it is now done using the seqlock_read_*
>>> primitives.
>>>
>>> Build tested on a FreeBSB/i386 VM with these applied:
>>>
>>> https://github.com/berrange/qemu/tree/freebsd-fixes
>>>
>>> There are still a ton of unrelated warnings being kicked out of the compiler
>>> though. On the VM "make check" fails at ... but as the build was
>>> broken beforehand I can't tell if this is a regression. It passes fine
>>> on my Linux box.
>>>
>>> Alex Bennée (2):
>>> cpus: don't use atomic_read for vm_clock_warp_start
>>> include/qemu/atomic: add compile time asserts
>>>
>>> cpus.c | 10 ++++++++-
>>> include/qemu/atomic.h | 58
>>> ++++++++++++++++++++++++++++++---------------------
>>> 2 files changed, 43 insertions(+), 25 deletions(-)
>>>
>>
>> Queued for 2.6, thanks. I will send a pull request later this week.
>
> It would be nice to fix this for rc1 (scheduled for tomorrow)...
Ok, I'll send it tomorrow then.
Paolo