[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virti
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/9] virtio-dataplane: pass assign=true to virtio_queue_aio_set_host_notifier_handler |
|
Date: |
Wed, 30 Mar 2016 15:43:02 +0200 |
On Wed, 30 Mar 2016 15:30:04 +0200
Paolo Bonzini <address@hidden> wrote:
> On 30/03/2016 15:23, Cornelia Huck wrote:
> > > There is no need to run the handler one last time; the device is being
> > > reset and it is okay to drop requests that are pending in the virtqueue.
> >
> > What about virtio_blk_save()? Could there be any pending requests in
> > that case?
>
> Those would be processed when dataplane is restarted on the destination
> side, I think. virtio_queue_set_host_notifier_fd_handler calls
> virtio_queue_host_notifier_read which connects the host notifier to the
> I/O thread and calls event_notifier_set to start processing it.
Makes sense; maybe mention that in the patch description as well?
- [Qemu-devel] [PATCH resend 0/9] virtio: aio handler API, Paolo Bonzini, 2016/03/30
- [Qemu-devel] [PATCH 4/9] virtio-scsi: fix disabled mode, Paolo Bonzini, 2016/03/30
- [Qemu-devel] [PATCH 5/9] virtio: add aio handler, Paolo Bonzini, 2016/03/30
- [Qemu-devel] [PATCH 2/9] virtio: make virtio_queue_notify_vq static, Paolo Bonzini, 2016/03/30
- [Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane, Paolo Bonzini, 2016/03/30