[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and UL
From: |
Joscha Benz |
Subject: |
Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and ULPI viewport from xilinx/qemu |
Date: |
Wed, 30 Mar 2016 12:46:26 +0200 |
Hi,
On 29.03.2016 22:23, Alistair Francis wrote:
> On Tue, Mar 29, 2016 at 12:51 PM, <address@hidden> wrote:
>> Signed-off-by: Joscha Benz <address@hidden>
>
> Hello Joscha ,
>
> Thanks for the patch. In future can you please use git send-email to
> send the patches instead of attaching the patch file. You can find
> more information on doing this at:
> http://wiki.qemu.org/Contribute/SubmitAPatch
Of course.
> What are you trying to do here? Why are you trying to apply the Xilinx
> model of the device? This relies on the register API (which you have
> included in your patch) which isn't in mainline QEMU yet, so that part
> can't be accepted just yet. We are working at upstreaming that at the
> moment though.
I was trying to get USB support for that device. That's why i tried to
apply the Xilinx model since it has USB support.
Regards,
Joscha