Re: [Qemu-devel] [PULL 00/40] ivshmem: Fixes, cleanups, device model split

[Peter Maydell]

On 18 March 2016 at 17:00, Markus Armbruster <address@hidden> wrote:
> Major issues addressed by this series:
>
> * The specification document is incomplete and vague.  Rewritten.
>
> * When a peer goes away, and its ID gets reused for another one,
>   interrupts don't work.
>
> * When configured for interrupts, we receive shared memory from the
>   server some time after realize().  This creates a (usually
>   short-lived) "no shared memory, yet" state.  If the guest wins the
>   race, it is exposed to this state (known issue, if you count burying
>   in docs/specs/ as "known").  If migration wins the race, it fails or
>   corrupts memory.
>
> * Interrupts are unreliable in a (usually small) time window after the
>   destination peer connects.  I believe fixing this will require
>   changing the client/server protocol, so just document it for now.
>
> * The device isn't capable to tell guest software whether it is
>   configured for interrupts.  Fix that in a new, backwards-compatible
>   revision of the guest ABI, and bump the PCI revision.  Deprecate the
>   old revision.
>
> * The device properties are a confusing mess and badly checked.
>   Clean that up.
>
> * Migration with interrupts relies on server behavior not guaranteed
>   by the specification.  Tighten the specification.
>
> The following changes since commit 6741d38ad0f2405a6e999ebc9550801b01aca479:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging 
> (2016-03-17 15:59:42 +0000)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-ivshmem-2016-03-18
>
> for you to fetch changes up to 9c4b53495c86f7c518e6daae6f98a349a9852009:
>
>   contrib/ivshmem-server: Print "not for production" warning (2016-03-18 
> 17:35:26 +0100)
>
> ----------------------------------------------------------------
> ivshmem: Fixes, cleanups, device model split
>

Hi; I'm afraid this fails 'make check' on OSX:

GTESTER check-qtest-i386
qemu-system-i386: invalid object type: memory-backend-file

Also some new clang ubsan warnings on x86 Linux:
GTESTER check-qtest-i386
[deleted existing warnings about slirp code]
/home/petmay01/linaro/qemu-for-merges/hw/pci/pci.c:166:23: runtime
error: shift exponent -1 is negative
/home/petmay01/linaro/qemu-for-merges/hw/pci/pci.c:171:24: runtime
error: shift exponent -1 is negative
/home/petmay01/linaro/qemu-for-merges/hw/pci/pci.c:172:24: runtime
error: shift exponent -1 is negative

thanks
-- PMM