Re: [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable

[Fam Zheng]

On Wed, 03/16 15:16, Stefan Hajnoczi wrote:
> Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move
> channel/transport functionality into wrapper class") stopped using the
> local err variable in channel_event_cb().
> 
> This patch deletes the unused variable.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  qga/main.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/qga/main.c b/qga/main.c
> index 0a168e2..743c5c1 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -618,13 +618,7 @@ static gboolean channel_event_cb(GIOCondition condition, 
> gpointer data)
>      GAState *s = data;
>      gchar buf[QGA_READ_COUNT_DEFAULT+1];
>      gsize count;
> -    GError *err = NULL;
>      GIOStatus status = ga_channel_read(s->channel, buf, 
> QGA_READ_COUNT_DEFAULT, &count);
> -    if (err != NULL) {
> -        g_warning("error reading channel: %s", err->message);
> -        g_error_free(err);
> -        return false;
> -    }
>      switch (status) {
>      case G_IO_STATUS_ERROR:
>          g_warning("error reading channel");
> -- 
> 2.5.0
> 
> 

Reviewed-by: Fam Zheng <address@hidden>