Re: [Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 15/03/2016 16:03, Markus Armbruster wrote:
>> diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h
>> index 2dabe49..904501a 100644
>> --- a/include/ui/qemu-spice.h
>> +++ b/include/ui/qemu-spice.h
>> @@ -23,6 +23,7 @@
>>  
>>  #include <spice.h>
>>  
>> +#include "qapi/error.h"
>>  #include "qemu/option.h"
>>  #include "qemu/config-file.h"
>>  
>
> This must be moved outside the #ifdef CONFIG_SPICE, because
> ui/qemu-spice.h uses error_set call outside that #ifdef.

Oops!

The inline function seems ill-advised to me, but let's avoid patch
series creep.  I'll fix it the way you described.