Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 15/03/2016 10:29, Markus Armbruster wrote:
>> NEED_CPU_H further adds
>> 
>>     include/disas/bfd.h
>>     include/exec/cpu-all.h
>>     include/exec/cpu-common.h
>>     include/exec/cpu-defs.h
>>     include/exec/exec-all.h
>>     include/exec/hwaddr.h
>>     include/exec/memattrs.h
>>     include/exec/memory.h
>>     include/hw/hotplug.h
>>     include/hw/i386/apic.h
>>     include/hw/irq.h
>>     include/hw/qdev-core.h
>>     include/qemu/bitmap.h
>>     include/qemu/bitops.h
>>     include/qemu/int128.h
>>     include/qemu/log.h
>>     include/qemu/notify.h
>>     include/qemu/rcu.h
>>     include/qemu/thread-posix.h
>>     include/qemu/thread.h
>>     include/qom/cpu.h
>>     include/qom/object.h
>>     include/standard-headers/asm-x86/hyperv.h
>>     include/standard-headers/linux/types.h
>>     target-i386/cpu-qom.h
>>     target-i386/cpu.h
>>     target-i386/svm.h
>>     tcg/i386/tcg-target.h
>>     x86_64-softmmu/config-target.h
>
> FWIW, I'm going to do something about this in 2.7.  I have patches to
> remove cpu.h inclusion from qemu-common.h.

Appreciated!

> Generally though qemu-common.h needs to go. :)

Yes.  The series I hope to post today is a baby step in that direction.