[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port |
Date: |
Mon, 14 Mar 2016 09:41:34 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/14/2016 05:41 AM, Christophe Fergeau wrote:
> Currently, virgl support has to go through a local unix socket, trying
> to connect to a VM using -spice gl through spice://localhost:5900 will
> only result in a black screen.
> This commit errors out when the user tries to start a VM with both GL
> support and a port/tls-port set.
> This would fit better in spice-server, but currently QEMU does not call
> into spice-server when parsing 'gl' on its command line, so we have to
> do this check in QEMU instead.
>
> Signed-off-by: Christophe Fergeau <address@hidden>
> ---
> ui/spice-core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 7987a4e..94f3236 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -844,6 +844,10 @@ void qemu_spice_init(void)
>
> #ifdef HAVE_SPICE_GL
> if (qemu_opt_get_bool(opts, "gl", 0)) {
> + if ((port != 0) || (tls_port != 0)) {
Overparenthesized; you could write:
if (port || tls_port) {
for the same effect with less typing.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port,
Eric Blake <=
Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port, Gerd Hoffmann, 2016/03/18