[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX s
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name |
Date: |
Thu, 10 Mar 2016 07:57:26 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
>
> On Wed, Mar 9, 2016 at 9:14 PM, Markus Armbruster <address@hidden> wrote:
>>> @@ -77,7 +77,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int
>>> argc, char *argv[])
>>> "F" /* foreground */
>>> "p:" /* pid_file */
>>> "S:" /* unix_socket_path */
>>> - "m:" /* shm_path */
>>> + "m:" /* dirname */
>>
>> The existing comments all name the member of args set by the option.
>> There is no member dirname.
>
> I read from help: "-m <dirname>: where to create shared memory"
Differently logical. In your interpretation, the comments are of very
little value. In mine, even less. That makes yours "superior".
>>> "M:" /* shm_path */
>>> "l:" /* shm_size */
>>> "n:" /* n_vectors */
[...]
- [Qemu-devel] [PATCH v2 03/42] target-ppc: Document TOCTTOU in hugepage support, (continued)
- [Qemu-devel] [PATCH v2 03/42] target-ppc: Document TOCTTOU in hugepage support, Markus Armbruster, 2016/03/07
- [Qemu-devel] [PATCH v2 06/42] qemu-doc: Fix ivshmem huge page example, Markus Armbruster, 2016/03/07
- [Qemu-devel] [PATCH v2 35/42] ivshmem: Inline check_shm_size() into its only caller, Markus Armbruster, 2016/03/07
- [Qemu-devel] [PATCH v2 20/42] ivshmem: Clean up register callbacks, Markus Armbruster, 2016/03/07
- [Qemu-devel] [PATCH v2 05/42] ivshmem-server: Don't overload POSIX shmem and file name, Markus Armbruster, 2016/03/07
[Qemu-devel] [PATCH v2 16/42] ivshmem: Drop ivshmem_event() stub, Markus Armbruster, 2016/03/07
[Qemu-devel] [PATCH v2 23/42] ivshmem: Assert interrupts are set up once, Markus Armbruster, 2016/03/07
[Qemu-devel] [PATCH v2 24/42] ivshmem: Simplify rejection of invalid peer ID from server, Markus Armbruster, 2016/03/07
[Qemu-devel] [PATCH v2 36/42] qdev: New DEFINE_PROP_ON_OFF_AUTO, Markus Armbruster, 2016/03/07
[Qemu-devel] [PATCH v2 25/42] ivshmem: Disentangle ivshmem_read(), Markus Armbruster, 2016/03/07
[Qemu-devel] [PATCH v2 40/42] ivshmem: Drop ivshmem property x-memdev, Markus Armbruster, 2016/03/07
[Qemu-devel] [PATCH v2 34/42] ivshmem: Simplify memory regions for BAR 2 (shared memory), Markus Armbruster, 2016/03/07