qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/8] usb: fix unbounded stack for usb_mtp_add_st


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 6/8] usb: fix unbounded stack for usb_mtp_add_str
Date: Tue, 08 Mar 2016 09:10:44 +0100

>  static void usb_mtp_add_str(MTPData *data, const char *str)
>  {
> +#define __WSTR_LEN (256)
>      uint32_t len = strlen(str)+1;
> -    wchar_t wstr[len];
> +    wchar_t wstr[__WSTR_LEN];

I think we should g_malloc() here.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]