Re: [Qemu-devel] Memory on stellaris board

[Aurelio Remonda]

On Thu, Feb 11, 2016 at 10:01 AM, Peter Maydell <address@hidden> wrote:

On 11 February 2016 at 12:46, Aurelio Remonda
<address@hidden> wrote:
> On Fri, Feb 5, 2016 at 2:00 PM, Peter Maydell <address@hidden> wrote:
>> The right way to do this is to set the MachineClass default_ram_size
>> to what you want your default value to be. Then you should calculate
>> the dc0 etc values to expose to the guest based on the ram size
>> (which might be the default or might be user specified).
>
> But stellaris board has a hardcoded dc0 value, when you place the -m flag
> with for example 256M you shouldn't calculate any sram_size from dc0, you
> just assign that as your ram size.

What I am suggesting is that dc0 should not be hardcoded, but
that you should work out what dc0 to use based on the user
provided RAM size.

thanks
-- PMM

Hello, sorry for taking so long, I am working on this again.

About your last response, I was looking at the struct stellaris_board_info ,which contains

dc0, and this entire struct is const. If we need to calculate dc0 based on the provided RAM size

or default value at least the dc0 field should not be const.

What do you think?
Thanks

--

Aurelio Remonda

Taller Technologies Argentina

Software Engineer

San Lorenzo 47, 3rd Floor, Office 5
Córdoba, Argentina
Phone: +54-351-4217888 / 4218211