Re: [Qemu-devel] [Qemu-arm] [PATCH] Fix bug: SRS instructions would trap to EL3 in Secure EL1 even if specified mode was not monitor mode. [RESUBMIT DUE TO MISSING SIGN-OFF]

[Peter Maydell]

On 22 February 2016 at 22:42, Ralf-Philipp Weinmann
<address@hidden> wrote:
> According to the ARMv8 Architecture reference manual [F6.1.203], ALL
> of the following conditions need to be met for SRS to trap to EL3:
> * It is executed at Secure PL1.
> * The specified mode is monitor mode.
> * EL3 is using AArch64.
>
> Signed-off-by: Ralf-Philipp Weinmann <address@hidden>

Thanks, nice catch. Did you find this by code inspection or
by some sort of test program or real guest code?

>      /* SRS is:
> -     * - trapped to EL3 if EL3 is AArch64 and we are at Secure EL1
> +     * - trapped to EL3 if EL3 is AArch64 and we are at Secure EL1 and
> +     *   mode is monitor mode

I tweaked this to say "specified mode is monitor mode" just to be
slightly clearer that we're not testing the mode we're currently in.
I have applied it to target-arm.next; thanks!

-- PMM