Re: [Qemu-devel] [PATCH V2 1/3] net/filter-traffic: add filter-traffic.h

[Zhang Chen]

On 03/03/2016 03:24 PM, Jason Wang wrote:
> On 03/03/2016 03:20 PM, Zhang Chen wrote:
> > On 03/03/2016 02:48 PM, Jason Wang wrote:
> > > On 03/02/2016 03:25 PM, Zhang Chen wrote:
> > > > On 03/02/2016 02:19 PM, Jason Wang wrote:
> > > > > On 02/29/2016 08:23 PM, Zhang Chen wrote:
> > > > > > We can reuse filter-traffic by filter-mirror,
> > > > > > filter-redirector and so on.
> > > > > I think we could share more than this. E.g just use filter-mirror.c to
> > > > > implement both mirror and redirector.
> > > > OK, should we change the name to filter-mirror? like filter-traffic?
> > > > and add redirect=on/off
> > > >
> > > > -object
> > > > filter-mirror,id=qtest-f0,netdev=qtest-bn0,queue=tx,indev=redirect0,redirect=on,outdev=mirror0
> > > I think we'd better use another type for this.
> > What is the "another type " ?
> > please tell me the detail for this.
> E.g. register another type like "filter-redirector" in reister_types()
> of filter-mirror.c.
>
> Thanks

OK, I get it. will change it in V3

> > Thanks
> > zhangchen
> >
> > >

--
Thanks
zhangchen