[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 29/38] ivshmem: Implement shm=... with a memory
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 29/38] ivshmem: Implement shm=... with a memory backend |
Date: |
Tue, 01 Mar 2016 13:08:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 29/02/2016 19:40, Markus Armbruster wrote:
>> ivshmem has its very own code to create and map shared memory.
>> Replace that with an implicitly created memory backend. Reduces the
>> number of ways we create BAR 2 from three to two.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Very appreciated, but do not use user_creatable_add_opts. Instead,
> create the object with object_initialize, object_property_set_* and
> user_creatable_complete. After the object_initialize, add it with
> object_property_add_child *under the ivshmem device itself*, giving it a
> name like "internal-shm-backend".
Will do.
> This matches what virtio-blk dataplane used to do for x-dataplane (now
> removed).
Note to self: commit a616fb7, try to steal that code.
Thanks!