[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse |
Date: |
Fri, 26 Feb 2016 12:53:02 +0000 |
On 26 February 2016 at 12:31, Shannon Zhao <address@hidden> wrote:
> So how about below patch? I've tested it and it works both for ACPI and
> DT. Could you help verify if it works for you? Thanks.
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 15658f4..4d45ea2 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -558,11 +558,20 @@ static void create_rtc(const VirtBoardInfo *vbi,
> qemu_irq *pic)
> g_free(nodename);
> }
>
> +#define GPIO_KEY_LATENCY 500 /* 500ms */
I don't understand why a 500ms pulse is better than a short one.
> +static QEMUTimer *gpio_key_timer;
This is state, and must be migrated somehow.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Michael Tokarev, 2016/02/03
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Peter Maydell, 2016/02/03
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Wei Huang, 2016/02/03
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Shannon Zhao, 2016/02/03
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Wei Huang, 2016/02/04
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Shannon Zhao, 2016/02/04
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Wei Huang, 2016/02/09
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Shannon Zhao, 2016/02/20
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Wei Huang, 2016/02/24
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Shannon Zhao, 2016/02/26
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Shannon Zhao, 2016/02/26
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Peter Maydell, 2016/02/26
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Wei Huang, 2016/02/26
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Peter Maydell, 2016/02/26
- Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse, Shannon Zhao, 2016/02/26