|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PULL 4/8] spice: reset cursor on resize |
Date: | Fri, 26 Feb 2016 00:10:16 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 23/02/2016 15:24, Gerd Hoffmann wrote: > qemu_mutex_lock(&ssd->lock); > + if (c) { > + cursor_get(c); > + } > + cursor_put(ssd->cursor); > + ssd->cursor = c; > ssd->hot_x = c->hot_x; > ssd->hot_y = c->hot_y; Coverity complains that this would dereference a NULL c, and I think it's right; either an unlock+return is missing, or the "if" is unnecessary. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |