Re: [Qemu-devel] [PATCH v7 0/4] trace: Show vCPU info in guest code events

[Lluís Vilanova]

Alex Bennée writes:

> Lluís Vilanova <address@hidden> writes:

>> Lluís Vilanova writes:
>> 
>>> NOTE: This series should complete the framework for guest code tracing. From
>>> here on, other series can concurrently add actual events and improve the
>>> guest code tracing features and performance (e.g., control tracing
>>> independently on each vCPU).
>> 
>>> This series introduces the "vcpu" property for tracing events. This property
>>> identifies events that are tied to a particular virtual CPU (e.g., 
>>> executing an
>>> instruction).
>> 
>>> Events with this property have an implicit vcpu argument, which is shown in 
>>> the
>>> trace. In the case of events executed at TCG translation time, two implicit
>>> arguments are added:
>> 
>>> * The vCPU performing the code translation (shown in the translation-time 
>>> trace)
>>> * The vCPU executing the translated code (shown in the execution-time trace)
>> 
>>> Note that the "vcpu" and "tcg" properties are not merged into a single one,
>>> since events can be defined that relate to a vCPU but are never raised from 
>>> TCG
>>> code (e.g., interrupts).
>> 
>> Hi,
>> 
>> I guess it's been a hectic time to integrate patches, but I haven't received 
>> a
>> comment on the tracing part since v4. If possible, I'd like to send an actual
>> guest code event (vmem accesses) before the soft-freeze (once this series is
>> accepted).

> I don't see a reason you couldn't post a v8 of this series including the
> actual use. It would help to see it being used in the wild and the
> maintainer doesn't have to accept the whole series straight away.
[...]
>>> Changes in v5
>>> =============
>> 
>>> * Rebase on 357e81c.
>>> * Split from the previous (larger and more complex) v4 series.

> Ahh I see it used to be. Perhaps maybe point to a public tree with the
> example use?

Ok, I'll send in parallel a separate series that exemplifies the general use of
the "vcpu" and "tcg" properties (the last was already accepted long ago).

But first, I'll send a new v8 of this series after testing events with all
possible TCG type arguments.


Thanks,
  Lluis