[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 8/8] pc: acpi: clarify why possible LAPIC entries
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH v3 8/8] pc: acpi: clarify why possible LAPIC entries must be present in MADT |
Date: |
Tue, 23 Feb 2016 17:06:00 +0100 |
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
---
hw/i386/acpi-build.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index e66c8b7..534a855 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -361,6 +361,12 @@ build_madt(GArray *table_data, GArray *linker,
PCMachineState *pcms)
if (apic_ids->cpus[i].cpu != NULL) {
apic->flags = cpu_to_le32(1);
} else {
+ /* ACPI spec says that LAPIC entry for non present
+ * CPU may be omitted from MADT or it must be marked
+ * as disabled. However omitting non present CPU from
+ * MADT breaks hotplug on linux. So possible CPUs
+ * should be put in MADT but kept disabled.
+ */
apic->flags = cpu_to_le32(0);
}
}
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/8] pc: do not create invalid MADT.LAPIC/Processor entries, Igor Mammedov, 2016/02/23
- [Qemu-devel] [PATCH v3 3/8] pc: acpi: cleanup qdev_get_machine() calls, Igor Mammedov, 2016/02/23
- [Qemu-devel] [PATCH v3 1/8] pc: init pcms->apic_id_limit once and use it throughout pc.c, Igor Mammedov, 2016/02/23
- [Qemu-devel] [PATCH v3 2/8] cpu: introduce possible-cpus interface, Igor Mammedov, 2016/02/23
- [Qemu-devel] [PATCH v3 6/8] pc: acpi: create Processor and Notify objects only for valid lapics, Igor Mammedov, 2016/02/23
- [Qemu-devel] [PATCH v3 5/8] pc: acpi: create MADT.lapic entries only for valid lapics, Igor Mammedov, 2016/02/23
- [Qemu-devel] [PATCH v3 8/8] pc: acpi: clarify why possible LAPIC entries must be present in MADT,
Igor Mammedov <=
- [Qemu-devel] [PATCH v3 4/8] pc: acpi: SRAT: create only valid processor lapic entries, Igor Mammedov, 2016/02/23
- [Qemu-devel] [PATCH v3 7/8] pc: acpi: drop cpu->found_cpus bitmap, Igor Mammedov, 2016/02/23