[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR |
Date: |
Tue, 23 Feb 2016 06:17:23 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 02/23/2016 02:01 AM, Changlong Xie wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
> ---
> block/quorum.c | 5 +++++
> docs/qmp-events.txt | 18 ++++++++++++++++++
> qapi/event.json | 16 ++++++++++++++++
> 3 files changed, 39 insertions(+)
In addition to Berto's findings:
> +++ b/docs/qmp-events.txt
> @@ -340,6 +340,24 @@ Example:
>
> Note: this event is rate-limited.
>
> +QUORUM_FLUSH_ERROR
> +-----------------
Please keep the file sorted; this would fall between QUORUM_FAILURE and
QUORUM_REPORT_BAD. Commit message should say why we need a third event,
rather than reusing either of the other two (my guess: because you don't
have a location, and don't want to modify the existing two to report a
location - but why not just use 'sector-num':0, 'sectors-count':<size of
file> to report the entire file as the location?)
Length of ---- separator should match text above it (you were off by one).
Is this event rate-limited? Should it be?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v4 2/2] quorum: modify vote rules for flush operation, Changlong Xie, 2016/02/23