qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevB


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH 02/17] chardev: Shorten references into ChardevBackend
Date: Mon, 22 Feb 2016 10:16:10 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

On Fri, Feb 19, 2016 at 05:19:32PM -0700, Eric Blake wrote:
> An upcoming patch will alter how simple unions, like ChardevBackend,
> are laid out, which will impact all lines of the form 'backend->u.XXX'.
> To minimize the impact of that patch, use a temporary variable to
> reduce the number of lines needing modification when an internal
> reference within ChardevBackend changes layout.
> 
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  qemu-char.c | 122 
> ++++++++++++++++++++++++++++++++----------------------------
>  1 file changed, 66 insertions(+), 56 deletions(-)

Reviewed-By: Daniel P. Berrange <address@hidden>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]