[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl
From: |
xiaoqiang zhao |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/14] hw/timer: QOM'ify milkymist_sysctl |
Date: |
Thu, 18 Feb 2016 07:56:38 +0800 |
I have sent the v3, which fix this problem.
> 在 2016年2月16日,02:14,Peter Maydell <address@hidden> 写道:
>
>> On 27 January 2016 at 02:54, xiaoqiang zhao <address@hidden> wrote:
>> * split milkymist_sysctl_init into milkymist_sysctl_info.instance_init and
>> milkymist_sysctl_realize
>
> I think the "info" in this function name is wrong ?
>
>> * use DeviceClass::realize instead of SysBusDeviceClass::init
>
> Please make sure you line wrap your commit messages (at somewhere
> around 70-72 columns is usual).
>
> Otherwise:
> Reviewed-by: Peter Maydell <address@hidden>
>
> Again, you should cc the maintainer for this device.
>
> thanks
> -- PMM
>