[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 5/9] target-arm/translate-a64.c: Use extract3
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-devel] [PATCH v1 5/9] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9 |
Date: |
Wed, 17 Feb 2016 00:09:13 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 12.02.2016 17:33, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <address@hidden>
>
> Use extract32 instead of open coding the bit masking when decoding
> is_signed and is_extended. This streamlines the decoding with some
> of the other ldst variants.
>
> No functional change.
>
> Signed-off-by: Edgar E. Iglesias <address@hidden>
Reviewed-by: Sergey Fedorov <address@hidden>
> ---
> target-arm/translate-a64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 7f65aea..bf31f8a 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -2117,8 +2117,8 @@ static void disas_ldst_reg_imm9(DisasContext *s,
> uint32_t insn)
> return;
> }
> is_store = (opc == 0);
> - is_signed = opc & (1<<1);
> - is_extended = (size < 3) && (opc & 1);
> + is_signed = extract32(opc, 1, 1);
> + is_extended = (size < 3) && extract32(opc, 0, 1);
> }
>
> switch (idx) {
- [Qemu-devel] [PATCH v1 0/9] arm: Steps towards EL2 support round 6, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 1/9] tcg: Add tcg_set_insn_param, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 2/9] gen-icount: Use tcg_set_insn_param, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 3/9] target-arm: Add the thumb/IL flag to syn_data_abort, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 4/9] target-arm: Add more fields to the data abort syndrome generator, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 5/9] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9, Edgar E. Iglesias, 2016/02/12
- Re: [Qemu-devel] [PATCH v1 5/9] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9,
Sergey Fedorov <=
- [Qemu-devel] [PATCH v1 6/9] target-arm/translate-a64.c: Unify some of the ldst_reg decoding, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 7/9] target-arm: Add the ARMInsnSyndrome type, Edgar E. Iglesias, 2016/02/12
- [Qemu-devel] [PATCH v1 8/9] target-arm: A64: Create Instruction Syndromes for Data Aborts, Edgar E. Iglesias, 2016/02/12
[Qemu-devel] [PATCH v1 9/9] target-arm: Use isyn.swstep.ex to hold the is_ldex state, Edgar E. Iglesias, 2016/02/12