Re: [Qemu-devel] [PATCH 3/8] virtio: add AioContext-specific function for host notifiers

[Cornelia Huck]

On Tue, 16 Feb 2016 15:20:17 +0800
Fam Zheng <address@hidden> wrote:

> On Sun, 02/14 18:17, Paolo Bonzini wrote:

> > +void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext 
> > *ctx,
> > +                                                bool assign, bool 
> > set_handler)
> > +{
> > +    if (assign && set_handler) {
> > +        aio_set_event_notifier(ctx, &vq->host_notifier, true,
> > +                               virtio_queue_host_notifier_read);
> > +    } else {
> > +        aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL);
> > +    }
> > +    if (!assign) {
> > +        /* Test and clear notifier before after disabling event,
> 
> Does "before after" mean "after"? :)

I think that was copied verbatim from
virtio_queue_set_host_notifier_fd_handler :)