[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump"
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump" |
Date: |
Tue, 16 Feb 2016 14:58:59 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Feb 16, 2016 at 02:40:59PM +0800, Fam Zheng wrote:
> On Wed, 12/09 10:42, Peter Xu wrote:
> > - s->status = (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED);
> > - error_propagate(errp, local_err);
>
> This means the error is released by caller, ...
>
> > + /* make sure status is written after written_size updates */
> > + smp_wmb();
> > + atomic_set(&s->status,
> > + (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED));
>
> but it is removed now. Is local_err leaked now?
Right. Lost it during switching of patches and merges. Will
fix. Thanks!
Peter