[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/8] acpi: add aml_concatenate()
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/8] acpi: add aml_concatenate() |
Date: |
Mon, 15 Feb 2016 10:19:33 +0100 |
On Sun, 14 Feb 2016 16:50:59 +0800
Xiao Guangrong <address@hidden> wrote:
> It will be used by nvdimm acpi
>
> Signed-off-by: Xiao Guangrong <address@hidden>
> ---
> hw/acpi/aml-build.c | 8 ++++++++
> include/hw/acpi/aml-build.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 2cc3211..3362cc4 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -1437,6 +1437,14 @@ Aml *aml_alias(const char *source_object, const char
> *alias_object)
> return var;
> }
>
> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefConcat */
> +Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target)
> +{
> + assert(target);
you don't need assert here
> + return build_opcode_2arg_dst(0x73 /* ConcatOp */, source1, source2,
> + target);
> +}
> +
> void
> build_header(GArray *linker, GArray *table_data,
> AcpiTableHeader *h, const char *sig, int len, uint8_t rev,
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 8ef10ad..735c34a 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -355,6 +355,7 @@ Aml *aml_touuid(const char *uuid);
> Aml *aml_unicode(const char *str);
> Aml *aml_derefof(Aml *arg);
> Aml *aml_sizeof(Aml *arg);
> +Aml *aml_concatenate(Aml *source1, Aml *source2, Aml *target);
>
> void
> build_header(GArray *linker, GArray *table_data,
- [Qemu-devel] [PATCH v3 0/8] NVDIMM ACPI: introduce the framework of QEMU emulated DSM, Xiao Guangrong, 2016/02/14
- [Qemu-devel] [PATCH v3 2/8] acpi: add aml_concatenate(), Xiao Guangrong, 2016/02/14
- Re: [Qemu-devel] [PATCH v3 2/8] acpi: add aml_concatenate(),
Igor Mammedov <=
- [Qemu-devel] [PATCH v3 1/8] acpi: add aml_create_field(), Xiao Guangrong, 2016/02/14
- [Qemu-devel] [PATCH v3 7/8] nvdimm acpi: emulate dsm method, Xiao Guangrong, 2016/02/14
- [Qemu-devel] [PATCH v3 5/8] nvdimm acpi: introduce patched dsm memory, Xiao Guangrong, 2016/02/14
- [Qemu-devel] [PATCH v3 3/8] acpi: allow using object as offset for OperationRegion, Xiao Guangrong, 2016/02/14
- [Qemu-devel] [PATCH v3 4/8] nvdimm acpi: initialize the resource used by NVDIMM ACPI, Xiao Guangrong, 2016/02/14
- [Qemu-devel] [PATCH v3 6/8] nvdimm acpi: let qemu handle _DSM method, Xiao Guangrong, 2016/02/14
- [Qemu-devel] [PATCH v3 8/8] nvdimm acpi: add _CRS, Xiao Guangrong, 2016/02/14