Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

[John Snow]

On 02/10/2016 07:48 AM, Paolo Bonzini wrote:
> 
> 
> On 09/02/2016 17:13, Paolo Bonzini wrote:
>> The following changes since commit ac1be2ae6b2995b99430c48329eb971b0281acf1:
>>
>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-02-09' 
>> into staging (2016-02-09 11:42:43 +0000)
>>
>> are available in the git repository at:
>>
>>   git://github.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to 150dcd1aed6f9ebcf370dbb9b666e7d7c6d908e2:
>>
>>   qemu-char, io: fix ordering of arguments for UDP socket creation 
>> (2016-02-09 17:09:15 +0100)
>>
>> ----------------------------------------------------------------
>> * switch to C11 atomics (Alex)
>> * Coverity fixes for IPMI (Corey), i386 (Paolo), qemu-char (Paolo)
>> * at long last, fail on wrong .pc files if -m32 is in use (Daniel)
>> * qemu-char regression fix (Daniel)
>> * SAS1068 device (Paolo)
>> * memory region docs improvements (Peter)
>> * target-i386 cleanups (Richard)
>> * qemu-nbd docs improvements (Sitsofe)
>> * thread-safe memory hotplug (Stefan)
>>
>> ----------------------------------------------------------------
>>
>> v2->v3: rebased due to semantic conflict, split MAINTAINERS patch
>>
>> Alex Bennée (1):
>>       include/qemu/atomic.h: default to __atomic functions
>>
>> Andrew Jones (1):
>>       kvm-all: trace: strerror fixup
>>
>> Corey Minyard (2):
>>       ipmi_bmc_sim: Fix off by one in check.
>>       ipmi_bmc_sim: Add break to correct watchdog NMI check
>>
>> Daniel P. Berrange (2):
>>       configure: sanity check the glib library that pkg-config finds

Appears to break clang 3.5.0 on F22;

address@hidden ((977a82a...)) ~/s/q/b/git> ../../configure --cxx=clang++
--cc=clang --host-cc=clang --extra-cflags=-Werror
--extra-cflags=-fsanitize=undefined
--extra-cflags=-Wno-deprecated-declarations
--extra-cflags=-fno-sanitize=float-divide-by-zero
--target-list="x86_64-softmmu"

ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
       You probably need to set PKG_CONFIG_LIBDIR
       to point to the right pkg-config files for your
       build target



Problem appears to be this:

/usr/include/glib-2.0/glib/gmem.h:76:58: error: unknown attribute
'__alloc_size__' ignored [-Werror,-Wunknown-attributes]
gpointer g_malloc         (gsize         n_bytes) G_GNUC_MALLOC
G_GNUC_ALLOC_SIZE(1);
                                                                ^
/usr/include/glib-2.0/glib/gmacros.h:67:45: note: expanded from macro
'G_GNUC_ALLOC_SIZE'
#define G_GNUC_ALLOC_SIZE(x) __attribute__((__alloc_size__(x)))


>>       char: fix repeated registration of tcp chardev I/O handlers
>>
>> Janosch Frank (1):
>>       scripts/kvm/kvm_stat: Fix tracefs access checking
>>
>> John Snow (1):
>>       nbd: avoid unaligned uint64_t store
>>
>> Paolo Bonzini (9):
>>       memory: add early bail out from cpu_physical_memory_set_dirty_range
>>       qemu-char: Keep pty slave file descriptor open until the master is 
>> closed
>>       scsi: push WWN fields up to SCSIDevice
>>       scsi-generic: grab device and port SAS addresses from backend
>>       hw: Add support for LSI SAS1068 (mptsas) device
>>       ipmi: do not take/drop iothread lock
>>       target-i386: fix PSE36 mode
>>       get_maintainer.pl: fall back to git if only lists are found
>>       qemu-char, io: fix ordering of arguments for UDP socket creation
>>
>> Peter Maydell (1):
>>       docs/memory.txt: Improve list of different memory regions
>>
>> Richard Henderson (10):
>>       target-i386: Create gen_lea_v_seg
>>       target-i386: Introduce mo_stacksize
>>       target-i386: Use gen_lea_v_seg in gen_lea_modrm
>>       target-i386: Use gen_lea_v_seg in stack subroutines
>>       target-i386: Access segs via TCG registers
>>       target-i386: Use gen_lea_v_seg in pusha/popa
>>       target-i386: Rewrite gen_enter inline
>>       target-i386: Rewrite leave
>>       target-i386: Tidy gen_add_A0_im
>>       target-i386: Deconstruct the cpu_T array
>>
>> Sitsofe Wheeler (3):
>>       qemu-nbd: Fix unintended texi verbatim formatting
>>       qemu-nbd: Minor texi updates
>>       qemu-nbd: Fix texi sentence capitalisation
>>
>> Stefan Hajnoczi (1):
>>       memory: RCU ram_list.dirty_memory[] for safe RAM hotplug
>>
>> Stephen Warren (1):
>>       MAINTAINERS: add all-match entry for qemu-devel@
>>
>>  MAINTAINERS               |    5 +
>>  configure                 |   24 +
>>  default-configs/pci.mak   |    1 +
>>  docs/memory.txt           |   26 +-
>>  exec.c                    |   75 +-
>>  hw/ipmi/ipmi.c            |    2 -
>>  hw/ipmi/ipmi_bmc_sim.c    |    4 +-
>>  hw/scsi/Makefile.objs     |    1 +
>>  hw/scsi/mpi.h             | 1153 ++++++++++++++++++++++++++++++
>>  hw/scsi/mptconfig.c       |  904 ++++++++++++++++++++++++
>>  hw/scsi/mptendian.c       |  204 ++++++
>>  hw/scsi/mptsas.c          | 1441 +++++++++++++++++++++++++++++++++++++
>>  hw/scsi/mptsas.h          |  100 +++
>>  hw/scsi/scsi-disk.c       |   23 +-
>>  hw/scsi/scsi-generic.c    |   92 +++
>>  include/exec/ram_addr.h   |  193 ++++-
>>  include/hw/pci/pci_ids.h  |    1 +
>>  include/hw/scsi/scsi.h    |    3 +
>>  include/qemu/atomic.h     |  192 +++--
>>  io/channel-socket.c       |    2 +-
>>  kvm-all.c                 |    4 +-
>>  migration/ram.c           |    4 -
>>  nbd/server.c              |   20 +-
>>  qemu-char.c               |   10 +-
>>  qemu-nbd.texi             |   80 ++-
>>  scripts/get_maintainer.pl |    2 +-
>>  scripts/kvm/kvm_stat      |   23 +-
>>  target-i386/helper.c      |    4 +-
>>  target-i386/helper.h      |    4 -
>>  target-i386/seg_helper.c  |   74 --
>>  target-i386/translate.c   | 1725 
>> +++++++++++++++++++++------------------------
>>  trace-events              |   22 +
>>  32 files changed, 5223 insertions(+), 1195 deletions(-)
>>  create mode 100644 hw/scsi/mpi.h
>>  create mode 100644 hw/scsi/mptconfig.c
>>  create mode 100644 hw/scsi/mptendian.c
>>  create mode 100644 hw/scsi/mptsas.c
>>  create mode 100644 hw/scsi/mptsas.h
>>
> 
> Self-NACK, this breaks (at least) FreeDOS.
> 
> Paolo
>