[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_nex
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit |
|
Date: |
Wed, 10 Feb 2016 18:44:06 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 10.02.2016 15:11, Paolo Bonzini wrote:
> The last two arguments to these functions are the last and first bit to
> check relative to the base. The code was using incorrectly the first
> bit and the number of bits. Fix this in cpu_physical_memory_get_dirty
> and cpu_physical_memory_all_dirty. This requires a few changes in the
> iteration; change the code in cpu_physical_memory_set_dirty_range to
> match.
>
> Fixes: 5b82b70
> Cc: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
That commit 5b82b70 also broke the pseries machine on qemu-ppc64:
--------------------------------- 8< --------------------------------------
$ ppc64-softmmu/qemu-system-ppc64 -net none -nographic -vga none
SLOF **********************************************************************
QEMU Starting
Build Date = Nov 5 2015 15:23:31
FW Version = git-b4c93802a5b2c72f
Press "s" to enter Open Firmware.
SLOF **********************************************************************
QEMU Starting
Build Date = Nov 5 2015 15:23:31
FW Version = git-b4c93802a5b2c72f
ERROR: Flatten device tree not available!
Press "s" to enter Open Firmware.
!!! roomfs lookup(bootinfo) = 1
Cannot find romfs file xvect
!!! roomfs lookup(bootinfo) = 1
ERROR: Not enough memory for Open Firmware
qemu: fatal: Trying to execute code outside RAM or ROM at 0xffffffffffbf0000
--------------------------------- 8< --------------------------------------
With your patch here applied, SLOF boots fine again, so:
Tested-by: Thomas Huth <address@hidden>