qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in


From: Hollis Blanchard
Subject: Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in memory tracepoints
Date: Tue, 9 Feb 2016 09:31:23 -0800
User-agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 02/09/2016 07:53 AM, Stefan Hajnoczi wrote:
On Mon, Feb 08, 2016 at 04:03:05PM -0800, Hollis Blanchard wrote:
-memory_region_ops_read(void *mr, uint64_t offset, uint64_t value, unsigned size) "mr %p offset 
%#"PRIx64" value %#"PRIx64" size %u"
-memory_region_ops_write(void *mr, uint64_t offset, uint64_t value, unsigned size) "mr %p offset 
%#"PRIx64" value %#"PRIx64" size %u"
+memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsigned size) "mr %p offset 
%#"PRIx64" value %#"PRIx64" size %u"
+memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, unsigned size) "mr %p offset 
%#"PRIx64" value %#"PRIx64" size %u"
Please update the format string too ("offset" -> "addr").

Oops, thanks. Do you want me to re-send the series, or just this patch?

Hollis Blanchard
Mentor Graphics Emulation Division




reply via email to

[Prev in Thread] Current Thread [Next in Thread]