[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/11] acpi: add aml_create_field()
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/11] acpi: add aml_create_field() |
Date: |
Mon, 8 Feb 2016 11:47:35 +0100 |
On Wed, 13 Jan 2016 02:50:02 +0800
Xiao Guangrong <address@hidden> wrote:
> It will be used by nvdimm acpi
>
> Signed-off-by: Xiao Guangrong <address@hidden>
> ---
> hw/acpi/aml-build.c | 13 +++++++++++++
> include/hw/acpi/aml-build.h | 1 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 78e1290..97c9efb 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -1001,6 +1001,19 @@ Aml *create_field_common(int opcode, Aml *srcbuf, Aml
> *index, const char *name)
> return var;
> }
>
> +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateField */
> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name)
to match spec more closely pls do following:
s/index/bit_index/
s/len/num_bits/
> +{
> + Aml *var = aml_alloc();
> + build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */
> + build_append_byte(var->buf, 0x13); /* CreateFieldOp */
> + aml_append(var, srcbuf);
> + aml_append(var, index);
> + aml_append(var, len);
> + build_append_namestring(var->buf, "%s", name);
> + return var;
> +}
> +
> /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateDWordField */
> Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name)
> {
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 6d6f705..e1ba534 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -346,6 +346,7 @@ Aml *aml_mutex(const char *name, uint8_t sync_level);
> Aml *aml_acquire(Aml *mutex, uint16_t timeout);
> Aml *aml_release(Aml *mutex);
> Aml *aml_alias(const char *source_object, const char *alias_object);
> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name);
> Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name);
> Aml *aml_create_qword_field(Aml *srcbuf, Aml *index, const char *name);
> Aml *aml_varpackage(uint32_t num_elements);
- Re: [Qemu-devel] [PATCH v2 03/11] acpi: add aml_create_field(),
Igor Mammedov <=