Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState

[Hailiang Zhang]

On 2016/2/4 19:10, Dr. David Alan Gilbert wrote:
> * Amit Shah (address@hidden) wrote:
> > On (Thu) 04 Feb 2016 [10:50:16], Dr. David Alan Gilbert wrote:
> > > * Amit Shah (address@hidden) wrote:
> > > > On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote:
> > > > > Rename the 'file' member of MigrationState to 'to_dst_file'.
> > > >
> > > > Why?
> > > >
> > > > (Use this space to explain why you're doing it, rather than repeating
> > > > the first line of the commit.  It helps when reviewing the git logs
> > > > later.)
> > >
> > > I think the simple answer is consistency; now we've got a bidirectional
> > > connection we've already got to_src_file, from_src_file and from_dst_file,
> > > so 'file' is an oddity that I was too lazy to rename previously.
> >
> > Sure, I just mean we need better commit description.  Just provide
> > one, and I'll use that when doing the pull req.
>
> I suggest:
>
> Rename the 'file' memory of MigrationState to 'to_dst_file' to
> be consistent with to_src_file, from_src_file and from_dst_file.

A very Good suggestion, thanks.

> Dave
>
> > Thanks,
> >
> >                 Amit
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
>
> .