[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 00/37] qapi visitor cleanups (post-introspect
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v9 00/37] qapi visitor cleanups (post-introspection cleanups subset E) |
Date: |
Thu, 28 Jan 2016 18:56:22 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> Based on qemu.git master. Pending prerequisites:
> + Not a strong dependency, but for qapi-tests to consistently pass,
> I needed a race fixed:
> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01827.html
Commit a174da3.
Series needs a rebase now. I figure there are enough actionable review
insights to warrant a full respin.
However, the series' length makes review taxing. Could you try to split
off an easier part for hopefully quick merging?
Non-easy topics, from memory:
* Retrofitting a contract to visitors.
* Shall we require visit_end_FOO() even after error? I have to admit
review dampened my enthusiasm for this idea.
* PATCH 30+
[...]
- [Qemu-devel] [PATCH v9 34/37] qapi: Simplify semantics of visit_next_list(), (continued)
[Qemu-devel] [PATCH v9 14/37] qapi: Swap visit_* arguments for consistent 'name' placement, Eric Blake, 2016/01/19
Re: [Qemu-devel] [PATCH v9 00/37] qapi visitor cleanups (post-introspection cleanups subset E),
Markus Armbruster <=