Re: [Qemu-devel] [PATCH v2 2/5] qapi: switch x-input-send-event from console to device+head

[Eric Blake]

On 01/26/2016 07:07 AM, Gerd Hoffmann wrote:
> Use display device qdev id and head number instead of console index to
> specify the QemuConsole.  This makes things consistent with input
> devices (for input routing) and vnc server configuration, which both use
> display and head too.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> Reviewed-by: Daniel P. Berrange <address@hidden>
> ---
>  qapi-schema.json | 32 +++++++++++++++++---------------
>  qmp-commands.hx  | 17 +++++++++--------
>  ui/input.c       | 15 ++++++++++-----
>  3 files changed, 36 insertions(+), 28 deletions(-)
> 

Might be worth a mention in the commit message that the change is
acceptable because it is to an 'x-' command (and that a later patch will
rename the command).

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature